gcalcli icon indicating copy to clipboard operation
gcalcli copied to clipboard

Internal maintenance: Enable branch protection on master

Open dbarnett opened this issue 1 year ago • 4 comments

Could we change GitHub project settings to avoid pushing changes straight to master without a PR? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule#creating-a-branch-protection-rule

@insanum will need your help for that since I don't have permission to configure project Settings. Just minimal branch protection settings ideally, where the systems nudge you to create a PR instead of pushing directly to master, but repo maintainers can still opt to override the protection if needed.

dbarnett avatar Aug 24 '24 17:08 dbarnett

BTW @mdengler @jcrowgey any concerns if I rename the master branch to main?

dbarnett avatar Aug 24 '24 17:08 dbarnett

go for it

mdengler avatar Aug 24 '24 19:08 mdengler

go for it

agreed

insanum avatar Aug 24 '24 21:08 insanum

No concerns

On August 24, 2024 10:58:15 AM PDT, David Barnett @.***> wrote:

BTW @mdengler @jcrowgey any concerns if I rename the master branch to main?

-- Reply to this email directly or view it on GitHub: https://github.com/insanum/gcalcli/issues/699#issuecomment-2308474245 You are receiving this because you were mentioned.

Message ID: @.***>

jcrowgey avatar Aug 25 '24 14:08 jcrowgey

@insanum still need your help on this, I don't have permission to access the repo's settings menu here.

dbarnett avatar Aug 26 '24 20:08 dbarnett

Done. Renamed master to main and added branch protection requiring PRs for all commits. Force bypass is enabled for those of us who have write access to the repo.

insanum avatar Aug 27 '24 14:08 insanum