gcalcli icon indicating copy to clipboard operation
gcalcli copied to clipboard

Published 20 hours ago • verified publisher icon insanum

Add 'transparent' flag to 'add' to allow creation of non-Busy (Free) …

Open kda opened this issue 5 years ago • 5 comments

…events.

I use this to create all day events frequently. I don't want the day marked busy. So, I added this.

kda avatar Jan 29 '20 05:01 kda

This seems like a useful addition. But this needs a little work before I can merge it. Here are my two concerns:

  1. I'm not sure that "transparent" is the most transparent name for this flag, if you will. :) I believe I understand the metaphor, but perhaps --nonbusy would frame things in the same language the api and calendar app use. Or, there may be something better than that. I'd love to get input from other users here.

  2. As written, this breaks the tests. If you need help refactoring so that things still pass (ideally, you'd add to the testsuite as well), let me know.

jcrowgey avatar Jan 29 '20 06:01 jcrowgey

  1. I'm willing to change it to --nonbusy. I will give it a day or two for input.
  2. Yeah, I rushed it and only tested it manually for my application. I will improve the tests.

An etiquette and git question: (zero experience in the github world...) Do I create a new branch? (and create a new pull request?) Do I just continue to work on the existing branch? (and give a holler when I think it is ready to go.)

kda avatar Jan 29 '20 06:01 kda

  1. I'm willing to change it to --nonbusy. I will give it a day or two for input. 2. Yeah, I rushed it and only tested it manually for my application. I will improve the tests. An etiquette and git question: (zero experience in the github world...) Do I create a new branch? (and create a new pull request?) Do I just continue to work on the existing branch? (and give a holler when I think it is ready to go.)

No need to make a new PR. Beyond that, I'm happy for you to manage things as you see fit. Choose a new branch (you should be able to edit the PR to target a different source branch), or keep this branch and make changes. Squash your commits if you like. You can go so far as to force push and rewrite published history within your branch. As long as you own the branch, I won't worry about it.

Thanks for the PR! Looking forward to the changes.

jcrowgey avatar Jan 29 '20 06:01 jcrowgey