gcalcli icon indicating copy to clipboard operation
gcalcli copied to clipboard

"now" line duplicated in calm and calw

Open reagle opened this issue 6 years ago • 7 comments

I often have days with one or more dashed lines, whether I have something scheduled or not. What does it mean?

┬────────────┬
│Tuesday     │
┼────────────┼
│28 May **   │
│            │
│------------│
│            │
│------------│
│            │
│            │
│            │
│            │
│            │
│            │
│            │
┴────────────┴

reagle avatar May 28 '19 15:05 reagle

AFAIK, the dashed lines are suppose to signify "now". Like you, I have more than one. Since there should never be more than one now at a time, this seems like a bug.

FWIW, I can repro and I updated the issue name so that it seems more like a bug report.

jcrowgey avatar May 28 '19 18:05 jcrowgey

bug introduced by me in f3617d66e7e3972025a2ecc3626fe1fd7c13065

Fix written, just testing a few things before pushing

jcrowgey avatar May 28 '19 19:05 jcrowgey

I believe this branch https://github.com/insanum/gcalcli/tree/fix_now_marking should resolve our problems. It definitely seems to fix the issues I observed.

jcrowgey avatar May 28 '19 20:05 jcrowgey

gcalcli v4.1.1 is showing a dashed line on Friday rather than today, July 10. There are double asterisks today. What do those mean?

┬────────────┬────────────┬────────────┬────────────┬────────────┐
│Tuesday     │Wednesday   │Thursday    │Friday      │Saturday    │
┼────────────┼────────────┼────────────┼────────────┼────────────┤
│09 Jul      │10 Jul **   │11 Jul      │12 Jul      │13 Jul      │
│            │            │            │            │            │
│            │FOO         │            │------------│            │
│            │            │            │            │            │
│            │            │            │10:00am     │            │
│            │            │            │FOO & FOO   │            │
│            │            │            │            │            │
│            │            │            │            │            │
│            │            │            │            │            │
┴────────────┴────────────┴────────────┴────────────┴────────────┘

reagle avatar Jul 10 '19 21:07 reagle

Thank you for the report. I have reproduced.

(venv) jcrowgey@tsuga:~/src/gcalcli$ gcalcli add --allday 
Title: FOO
Location: 
When: today
Duration (days): 1
Description: 
Enter a valid reminder or "." to end: .
(venv) jcrowgey@tsuga:~/src/gcalcli$ gcalcli add
Title: FOO & FOO
Location: 
When: 10am friday
Duration (minutes): 60
Description: 
Enter a valid reminder or "." to end: .
(venv) jcrowgey@tsuga:~/src/gcalcli$ gcalcli calw
┌──────────┬──────────┬──────────┬──────────┬──────────┬──────────┬──────────┐
│Sunday    │Monday    │Tuesday   │Wednesday │Thursday  │Friday    │Saturday  │
├──────────┼──────────┼──────────┼──────────┼──────────┼──────────┼──────────┤
│07 Jul    │08 Jul    │09 Jul    │10 Jul ** │11 Jul    │12 Jul    │13 Jul    │
│          │          │          │          │          │          │          │
│          │          │          │FOO       │          │----------│          │
│          │          │          │          │          │          │          │
│          │          │          │          │          │10:00am   │          │
│          │          │          │          │          │FOO & FOO │          │
│          │          │          │          │          │          │          │
└──────────┴──────────┴──────────┴──────────┴──────────┴──────────┴──────────┘
(venv) jcrowgey@tsuga:~/src/gcalcli$ date -u
Wed 10 Jul 2019 09:48:29 PM UTC

The ** is supposed to be the "today" marker on the date. The -------- is the "now" line. As far as I know, it's wrong whenever they're not on the same day.

jcrowgey avatar Jul 10 '19 21:07 jcrowgey

Thanks for that. I'm glad it was easily reproduced and not the function of my specific calendar.

reagle avatar Jul 11 '19 11:07 reagle

What's interesting is that the bug seems related to my "fixes", heh.

jcrowgey@tsuga:~$ gcalcli calw
┌──────────┬──────────┬──────────┬──────────┬──────────┬──────────┬──────────┐
│Sunday    │Monday    │Tuesday   │Wednesday │Thursday  │Friday    │Saturday  │
├──────────┼──────────┼──────────┼──────────┼──────────┼──────────┼──────────┤
│07 Jul    │08 Jul    │09 Jul    │10 Jul    │11 Jul ** │12 Jul    │13 Jul    │
│          │          │          │          │          │          │          │
│          │          │          │FOO       │----------│10:00am   │          │
│          │          │          │          │          │FOO & FOO │          │
│          │          │          │          │          │          │          │
└──────────┴──────────┴──────────┴──────────┴──────────┴──────────┴──────────┘
jcrowgey@tsuga:~$ date -u
Thu 11 Jul 2019 04:10:59 PM UTC
jcrowgey@tsuga:~/src/gcalcli$ gcalcli --version
gcalcli v4.0.4 (Eric Davis, Brian Hartvigsen, Joshua Crowgey)
jcrowgey@tsuga:~$ cd src/gcalcli
jcrowgey@tsuga:~/src/gcalcli$ . venv/bin/activate
(venv) jcrowgey@tsuga:~/src/gcalcli$ gcalcli calw
┌──────────┬──────────┬──────────┬──────────┬──────────┬──────────┬──────────┐
│Sunday    │Monday    │Tuesday   │Wednesday │Thursday  │Friday    │Saturday  │
├──────────┼──────────┼──────────┼──────────┼──────────┼──────────┼──────────┤
│07 Jul    │08 Jul    │09 Jul    │10 Jul    │11 Jul ** │12 Jul    │13 Jul    │
│          │          │          │          │          │          │          │
│          │          │          │FOO       │          │----------│          │
│          │          │          │          │          │          │          │
│          │          │          │          │          │10:00am   │          │
│          │          │          │          │          │FOO & FOO │          │
│          │          │          │          │          │          │          │
└──────────┴──────────┴──────────┴──────────┴──────────┴──────────┴──────────┘
(venv) jcrowgey@tsuga:~/src/gcalcli$ gcalcli --version
gcalcli v4.1.1 (Eric Davis, Brian Hartvigsen, Joshua Crowgey)

jcrowgey avatar Jul 11 '19 16:07 jcrowgey