unicore-mx icon indicating copy to clipboard operation
unicore-mx copied to clipboard

Published 20 hours ago • verified publisher icon insane-adding-machines

incorrect naming

Open kuldeepdhaka opened this issue 8 years ago • 2 comments

https://github.com/insane-adding-machines/unicore-mx/blob/master/include/unicore-mx/stm32/common/adc_common_v2_single.h#L52 should be ADC_CFGR1_EXTSEL_MASK

kuldeepdhaka avatar Aug 02 '16 19:08 kuldeepdhaka

https://github.com/insane-adding-machines/unicore-mx/blob/cfc738cce04cb6bf815ae5377ed3dea25d9c02e4/include/unicore-mx/stm32/f0/adc.h#L82 should be ADC_SMPR_SMP_MASK

kuldeepdhaka avatar Aug 02 '16 19:08 kuldeepdhaka

@kuldeepdhaka entirely correct, nice catch! We can fix these, but we should note this down to check the headers for items as this with the overhaul.

brabo avatar Aug 04 '16 20:08 brabo