solid-client-authn-js icon indicating copy to clipboard operation
solid-client-authn-js copied to clipboard

Feat/prompt

Open jaxoncreed opened this issue 2 years ago • 2 comments

New feature description

Added the support to pass a prompt to the underlying oidc library. This was once a feature, but I think it might have been accidentally removed.

Checklist

  • [ ] All acceptance criteria are met.
  • [ ] Relevant documentation, if any, has been written/updated. (No. I don't have access to update Inrupt docs)
  • [X] The changelog has been updated, if applicable.
  • [X] New functions/types have been exported in index.ts, if applicable.
  • [X] Commits in this PR are minimal and have descriptive commit messages.

jaxoncreed avatar Aug 25 '23 00:08 jaxoncreed

Hi @jaxoncreed , thanks for opening this, and i'm sorry it took me so long to respond. The prompt parameter is set by the library internally to consent for requests including the offline_access scope (which is requested by default so that the library can use the refresh token to maintain authentication), and to none for silent authentication on page reload. What is the use case for exposing this parameter through the public API?

NSeydoux avatar Oct 08 '23 21:10 NSeydoux

No worries,

This would allow you to use the create prompt for servers that support it (https://openid.net/specs/openid-connect-prompt-create-1_0.html). Alternatively, we could have a separate function for create, but that might be confusing because not all Solid Servers support the create prompt.

jaxoncreed avatar Oct 17 '23 02:10 jaxoncreed