solid-client-authn-js
solid-client-authn-js copied to clipboard
Migrate to oidc-client-ts (successor project of oidc-client-js)
Search terms you've used
- oidc-client-js
- oidc-client-ts
Impacted environment
In which environment would the proposed feature apply ?
- [x] The browser
- [ ] Node.js
- [ ] Other (please specify): ...
- [x] I'm not sure.
Feature suggestion
Since oidc-client-js is no longer maintained and further development is instead going on in oidc-client-ts I would like to see this library use that maintained dependency.
Expected functionality/enhancement
This is part of my endeavour to support Solid Login within browser extensions and specififally migrating my extension to chrome manifest v3.
I am willing to adjust oidc-client-ts to support service workers, if solid-client-authn-js will then actually make use of it.
Actual functionality/enhancement
Currently solid-client-authn-js depends on a fork of oidc-client-js
There seem to be only a few changes to do this as #2206 shows. We still need to take a look at the details, but let me know what you think about using oidc-client-ts in general, before I move on with it.
Hi @angelo-v, and thanks for the suggestion! We are looking at some internal refactoring to the auth library pretty soon though, so I'm not sure doing this now would be the best timing. I'll update this issue soon (probably this week or next) with the planned changes to see if the issue still makes sense, is that ok with you?
Sounds good to me.
Please note that I managed to use solid-client-authn-js within a chrome extension by doing some manual setup of a ClientAuthentication with a custom redirector. I am using some internal types / imports from this lib. Everything is put together here. I wonder if this might break with your refactorings.
In general it would by very helpful if solid-client-authn-js would became more extensible and modular (I had to copy paste some code, rely on deep imports and instantiate a lot of classes although I only wanted to exchange the redirector and the logout handler). Will this be covered by the refactoring? I could create another issue for this. Perhaps we can even include support for browser extensions directly to solid-client-authn-js with what I have learned in my extension? What do you think?
Hi @NSeydoux how is it going? Any updates on the planned changes you mentioned? Did you have a chance to look into my customizations mentioned in the last comment?
Hi @angelo-v, sorry for the delayed response, we're still working on the plan and the changes, but it's a major refactor of this library, so takes quite an amount of time to plan. I'll try to get us to give an update when have more details to share.