solid-client-authn-js icon indicating copy to clipboard operation
solid-client-authn-js copied to clipboard

Use createRemoteJWKSet for ID token validation

Open pavol-brunclik-compote opened this issue 3 years ago • 1 comments

This PR fixes bug: Where when validating ID token against public key from JWKS store at index [0]. In case another private key was used to sign ID token, validation failed. Reintroduced usage of createRemoteJWKSet for ID token validation + fixed tests using 'nock' library mocking requests to JWKS endpoint.

  • [x] I've added a unit test to test for potential regressions of this bug.
  • [x] The changelog has been updated, if applicable.
  • [x] Commits in this PR are minimal and have descriptive commit messages.

pavol-brunclik-compote avatar Sep 24 '21 17:09 pavol-brunclik-compote

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72e0740971c75a7ef9220e22f540a40191b1a5ac:

Sandbox Source
solid-client-auth-browser-demo Configuration

codesandbox-ci[bot] avatar Sep 24 '21 17:09 codesandbox-ci[bot]

This is now fixed by https://github.com/inrupt/solid-client-authn-js/commit/bd14278e0cc34b223f1e7b26cade8fc9fb73e833

NSeydoux avatar Mar 25 '24 08:03 NSeydoux