pod-browser icon indicating copy to clipboard operation
pod-browser copied to clipboard

Rename clientid template file

Open solid-akb opened this issue 3 years ago • 4 comments

Description

Renamed clientid template to clientid.example avoid confusion.

Changes

Testing

Commit checklist

  • [ ] All acceptance criteria are met.
  • [ ] Includes tests to ensure functionality and prevent regressions.
  • [ ] Relevant documentation, if any, has been written/updated.
  • [ ] The changelog has been updated, if applicable.

Interested parties

Notes

Screenshots/captures

solid-akb avatar Jul 22 '22 17:07 solid-akb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pod-browser ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 4:43PM (UTC)

vercel[bot] avatar Jul 22 '22 17:07 vercel[bot]

@ThisIsMissEm Agree that the current solution isn't the best one. Would love to do this together with you (or someone on Apps team if y'all understand comments above) as I don't understand well enough to implement.

solid-akb avatar Jul 23 '22 16:07 solid-akb

In the meantime, Laurin has created a neat tool that we can reference to instead of having this example client_id doc in our repo!

Thoughts on closing this PR and adding a line to the Readme?

solid-akb avatar Oct 18 '22 22:10 solid-akb

I think closing this and adding a line to readme is a great idea

On Tue, Oct 18, 2022 at 5:57 PM Anna Kallenborn-Bolden < @.***> wrote:

In the meantime, Laurin has created a neat tool https://vercel.com/inrupt/client-identifier-helper that we can reference to instead of having this example client_id doc in our repo!

Thoughts on closing this PR and adding a line to the Readme?

— Reply to this email directly, view it on GitHub https://github.com/inrupt/pod-browser/pull/503#issuecomment-1283103846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7SAMC2OPAFDY7OT5L3GMDWD4TMTANCNFSM54MGX32Q . You are receiving this because you were mentioned.Message ID: @.***>

-- This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged, confidential and/or proprietary information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), please do not disseminate, distribute, print or copy this e-mail, or any attachment thereto. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the email.

chelseapinka avatar Oct 19 '22 12:10 chelseapinka