stack2nix icon indicating copy to clipboard operation
stack2nix copied to clipboard

stack2nix doesn't work well with submodules

Open mpickering opened this issue 5 years ago • 4 comments

It seems that stack2nix first tries to clone the master branch for the given repo. This interacts poorly with submodules as they are initialised to the remote on master rather than the given revision.

If the commit you want to use contains submodules which point to a different remote then running stack2nix fails as it can't find the reference.

The way I "fixed" this was to push my branch to the master branch as well but obviously this is not possible in general.

mpickering avatar Apr 05 '19 22:04 mpickering

We've since switched almost exclusively to haskell.nix at iohk. See https://input-output-hk.github.io/haskell.nix/

angerman avatar Apr 06 '19 08:04 angerman

@angerman That's great but hie-nix still uses stack2nix which is where I ran into this issue. If hie-nix started using haskell.nix then this issue doesn't bother me.

mpickering avatar Apr 06 '19 18:04 mpickering

@domenkozar this is now squarely in your court ;-) I tried. Maybe this is a good opportunity for you to finally try haskell.nix and complain about all that’s wrong with it :-)

angerman avatar Apr 07 '19 03:04 angerman

I think we've fixed this bug at some point but could be it's still broken.

Given @mpickering has a workaround I'd rather delay any stack2nix improvements until I find time for haskell.nix and switch my projects to it.

domenkozar avatar Apr 07 '19 06:04 domenkozar