mithril icon indicating copy to clipboard operation
mithril copied to clipboard

Move GCP Aggregator to 'preview' network

Open jpraynaud opened this issue 2 years ago • 4 comments

This PR upgrades the Aggregator hosted on GCP cloud so that it uses the preview Cardano network instead of the legacy testnet:

  • [x] Upgrade Cardano node to 1.35.3
  • [x] Parametrize the docker-compose.yaml file so that it can be used with different network
  • [x] Update the poolIds of the Signer nodes (which poolIds are selected among the SPOs on the preview network) and reduce their number to 2
  • [x] Use preview network with NETWORK=preview NETWORK_MAGIC=2 in the aggregator.tf file
  • [x] Update documentation

After merge, manually duplicate stores data so that we don't need to wait 2 epochs before signing

Relates to #457

jpraynaud avatar Sep 01 '22 09:09 jpraynaud

Unit Test Results

    7 files  ±0    22 suites  ±0   1m 28s :stopwatch: -43s 293 tests ±0  293 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  294 runs  ±0  294 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit adbfbd49. ± Comparison against base commit e0916d3d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 01 '22 17:09 github-actions[bot]

There is a CardanoNetwork enum in mithril-common used in BeaconProvider & CliObserver. IMHO the enum variant CardanoNetwork::TestNet should be changed to Preview as well.

ghubertpalo avatar Sep 02 '22 12:09 ghubertpalo

There is a CardanoNetwork enum in mithril-common used in BeaconProvider & CliObserver. IMHO the enum variant CardanoNetwork::TestNet should be changed to Preview as well.

Actually, the parameters used with the commands to the cardano-cli will depend on the CardanoNetwork type.

IMHO it's better to have the CardanoNetwork::TestNet handles a Test Network which can either be:

  • testnet with magic id 1097911063
  • preprod with magic id 1
  • preview with magic id 2
  • private with any magic id

I have added a commit that implements this behavior and also enhances the computation of the CardanoNetwork from a config in the Signer/Aggregator.

Let me know if that works for you :slightly_smiling_face:

jpraynaud avatar Sep 02 '22 14:09 jpraynaud

Seems like this is just fine, can we merge it? Given the time it can take to register SPOs, the sooner the better

abailly-iohk avatar Sep 04 '22 12:09 abailly-iohk

Thanks a lot @jpraynaud. I understand there's manual work to be done for the deployment, definitely can wait tomorrow morning :)

abailly-iohk avatar Sep 04 '22 20:09 abailly-iohk