lace
lace copied to clipboard
[LW-9499] New wallet manager migration
Checklist
- [X] JIRA - https://input-output.atlassian.net/browse/LW-9499
- [ ] Proper tests implemented
- [ ] Screenshots added.
Proposed solution
Creates migration for newwallet manager
Testing
Unlocked wallet test
- Install the extension with main branch
- Create/import new wallet
- Build this branch, make sure the version in the manifest file is higher then that of the main branch (you might have to manually modify it)
- Install the extension with the new build
- Open lace and make sure it is working properly (to make sure the migration ran, verify that lock and keyAgentData are not present in localStorage)
Locked wallet test
- Repeat the process but lock the wallet after step 2.
Screenshots
Attach screenshots here if implementation involves some UI changes
Allure report
allure-report-publisher
generated test report!
smokeTests: ❌ test report for 1c0b289d
passed | failed | skipped | flaky | total | result | |
---|---|---|---|---|---|---|
Total | 1 | 30 | 0 | 0 | 31 | ❌ |
@lucas-barros for testing: should I remove the browser extension or just reload it with the new code?
@lucas-barros I'm getting this on running yarn dev
with this PR:
what could be wrong?
@lucas-barros for testing: should I remove the browser extension or just reload it with the new code?
You can use your current installation. I added the steps for testing in the description.
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Changes unknown when pulling 1c0b289d835f1f8d3331636bd77252b18ecaa88c on feat/lw-9499-migration into ** on LW-9094-new-wallet-manager**.
@lucas-barros the migration seems to be working for me now 👍 for me the wallet is getting locked after the migration (even if i never locked the wallet before), is this intentional? Btw. it's not locked anymore after closing the popup and re-opening it, so it doesn't seem to be enforced either.
@lucas-barros the migration seems to be working for me now 👍 for me the wallet is getting locked after the migration (even if i never locked the wallet before), is this intentional? Btw. it's not locked anymore after closing the popup and re-opening it, so it doesn't seem to be enforced either.
@DominikGuzei did you update the manifest file version to a higher then your current version? If not, likely the migration didnt run, the new build was loaded once (which will "lock" the wallet), then the older version would be reload due to the version being higher. What does your local storage look like after the migration?