lace icon indicating copy to clipboard operation
lace copied to clipboard

[LW-10451] Address book name broken on address input

Open lucas-barros opened this issue 9 months ago • 4 comments

Checklist

  • [x] JIRA - https://input-output.atlassian.net/browse/LW-10451
  • [x] Proper tests implemented
  • [x] Screenshots added.

Proposed solution

  • Prevent line break on white spaces
  • Add story to include scenario on snapshot test

Testing

Create an address book entry with a white space such as "My address" and verify that the name is displayed correctly in send flow.

Screenshots

image

lucas-barros avatar May 13 '24 19:05 lucas-barros

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 34fea0d9

passed failed skipped flaky total result
Total 30 0 0 0 30

github-actions[bot] avatar May 13 '24 19:05 github-actions[bot]

@lucas-barros In the core storybook i can see that the address book name doesn't look right (font color) on dark theme: image

DominikGuzei avatar May 14 '24 08:05 DominikGuzei

@lucas-barros In the core storybook i can see that the address book name doesn't look right (font color) on dark theme: image

@DominikGuzei that was due to switching from story with global theme to one with local theme. Fixed here: https://github.com/input-output-hk/lace/pull/1158/commits/75de21c9a48aeea74704e0295f487aebb8c82895.

lucas-barros avatar May 14 '24 12:05 lucas-barros