lace icon indicating copy to clipboard operation
lace copied to clipboard

feat(extension): add midnight pre-launch settings banner LW-10398

Open DominikGuzei opened this issue 9 months ago • 3 comments

Checklist

  • [x] JIRA
  • [x] Screenshots added.

Proposed solution

Please note: the CTA buttons do not have any action defined yet (as per task requirement) and will be wired-up in later tasks.

  • Introduce a USE_MIDNIGHT_PRELAUNCH_EVENT feature flag to hide the midnight related UI elements behind
  • Implement the midnight pre-launch banner in @lace/core storybook
  • Add the pre-launch ui setting item in the settings list (in all views)
  • Integrate the pre-launch banner in the settings sidebar (in extended view)

Testing

  • Check that no pre-launch settings items are shown when feature flag is off
  • With feature flag on check that the pre-launch settings item is always visible and the sidebar banner is visible in extended view in all responsive screen sizes except the smallest one.

Screenshots

video of the responsive banner sidebar banner (please note that at time of recording the settings list item was not yet activated for extended view but is in latest version):

https://github.com/input-output-hk/lace/assets/172414/075372c3-50b8-4330-868a-78aa34b8e4c2

DominikGuzei avatar May 13 '24 15:05 DominikGuzei

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 8b83c82e

passed failed skipped flaky total result
Total 30 0 0 0 30

github-actions[bot] avatar May 13 '24 15:05 github-actions[bot]

There is a small ts warning, but aside than that, this looks great to me!

Hmm … that looks weird because i don't think this is caused by my changes in this PR? image

DominikGuzei avatar May 14 '24 08:05 DominikGuzei