Chore/lw 10534 translation package

Open vetalcore opened this issue 9 months ago • 5 comments

Checklist

[x] JIRA -LW-10534
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution

Move all the translations files and i18n instance into the separate package.

Testing

All the translations should work the same as before.

Screenshots

~~Attach screenshots here if implementation involves some UI changes~~

May 11 '24 10:05 vetalcore

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for e7e4d1e4

	passed	failed	skipped	flaky	total	result
Total	30	0	0	0	30	✅

May 11 '24 10:05 github-actions[bot]

@vetalcore packages/e2e-tests/src/utils/translationService.ts will need updating to point at the correct browser-extension-wallet and core translation files, this should get the e2e tests running

May 13 '24 10:05 mchappell

Yeah i also wonder why the translations are still split up 🤔 since they are already namespaced it would make sense to merge them? (although we would have to namespace some of the extension translations i think)

May 14 '24 12:05 DominikGuzei

Yeah i also wonder why the translations are still split up 🤔 since they are already namespaced it would make sense to merge them? (although we would have to namespace some of the extension translations i think)

it's just easier to handle the changes this way, we could easily implement that as a next iteration.

May 15 '24 09:05 vetalcore