haskell.nix icon indicating copy to clipboard operation
haskell.nix copied to clipboard

`dont` prefixes are weird. (`dontStrip`, `dontPatchELF`)

Open angerman opened this issue 6 years ago • 4 comments

We have doHaddock, ... but dontStrip and dontPatchELF. This leads to some controversy.

This issue is here to discuss this specific issue and find a good solution. For now I'm ok with sticking with what nixpkgs does to make migrating from nixpkgs to Haskell.nix easier.

angerman avatar Dec 04 '19 02:12 angerman

I wonder if this is a problem that people would actually have? I don't think any human would be confused about the names not being the same as in nixpkgs (grep dontStrip, nothing, hmmm, grep Strip, got it), so it seems to me that the only way this could cause problems is if someone was trying to directly carry over some nix code that worked with the nixpkgs Haskell support to haskell.nix. But that's never going to work anyway!

michaelpj avatar Dec 04 '19 11:12 michaelpj

To be clear, I don't have a strong opinion. I'd be ok deviating if that's what decided. I was just going for the least surprise. But I also don't like the inconsistency and I really don't like having to reason about things like !dontStrip.

@michaelpj it's not just the Haskell support that has these weird names, it's stdenv.mkDerivation too! If it was just the Haskell infra in nixpkgs I would have made things more consistent here.

purefn avatar Dec 04 '19 15:12 purefn

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 28 '22 23:09 stale[bot]

Still annoying.

michaelpj avatar Sep 29 '22 09:09 michaelpj