haskell.nix icon indicating copy to clipboard operation
haskell.nix copied to clipboard

Delete `flake.lock` in `docs` to better catch issues in tests?!

Open yvan-sraka opened this issue 2 years ago • 3 comments

yvan-sraka avatar Oct 10 '22 08:10 yvan-sraka

I should also maybe remove https://github.com/input-output-hk/haskell.nix/blob/better-docs-testing/docs/tutorials/getting-started/nix/sources.json and rather run niv commands in tests?

yvan-sraka avatar Oct 10 '22 08:10 yvan-sraka

Ugh, this is a bit annoying. It's a shame we can't use the same pins as the top level flake or something. Not pinning means that this is a bit non-deterministic, which is kind of scary.

michaelpj avatar Oct 10 '22 09:10 michaelpj

symlink?

L-as avatar Oct 10 '22 10:10 L-as

symlink?

error: opening file '/nix/store/nhx8bikk1rakvmc2kbgjnpm8090rz0kj-source/docs/tutorials/getting-started-flakes/flake.lock': Too many levels of symbolic links
(use '--show-trace' to show detailed location information)

yvan-sraka avatar Nov 01 '22 08:11 yvan-sraka

If symlink does not work could we copy the flake.lock in the daily hackage.nix and stackage.nix update job?

hamishmack avatar Nov 02 '22 06:11 hamishmack

Is the flake.lock in haskell.nix suitable though? Maybe not.

hamishmack avatar Nov 02 '22 06:11 hamishmack

Could we remove docs/tutorials/getting-started-flakes/flake.lock and before running the tests run:

nix flake lock --override-input haskellNix ../../..

hamishmack avatar Nov 02 '22 07:11 hamishmack

Could we remove docs/tutorials/getting-started-flakes/flake.lock and before running the tests run:


nix flake lock --override-input haskellNix ../../..

I think that's the right solution, I will push it on this branch :)

yvan-sraka avatar Nov 02 '22 08:11 yvan-sraka

Merged in https://github.com/input-output-hk/haskell.nix/pull/1746

yvan-sraka avatar Dec 03 '22 17:12 yvan-sraka