cardano-node icon indicating copy to clipboard operation
cardano-node copied to clipboard

KeepAlive tracing improvements

Open coot opened this issue 8 months ago • 0 comments
trafficstars

Description

  • new tracing system: moved instances to NodeToNode module, where other mini-protocol tracers are defined.
  • make the output of the legacy tracing system for keep alive measurements, the same as the new one.

Checklist

  • [ ] Commit sequence broadly makes sense and commits have useful messages
  • [ ] New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests See Runnings tests for more details
  • [ ] Any changes are noted in the CHANGELOG.md for affected package
  • [ ] The version bounds in .cabal files are updated
  • [ ] CI passes. See note on CI. The following CI checks are required:
    • [ ] Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • [ ] Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • [ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • [x] Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons. You will need to get someone with write privileges. Please contact IOG node developers to do this for you.

coot avatar Mar 20 '25 10:03 coot