cardano-node
cardano-node copied to clipboard
Change watchEpochStateUpdate callback type
Description
This PR changes watchEpochStateUpdate
callback type from a sum type Maybe a
to a product (LedgerStateCondition, a)
, which allows to return from the function, when the condition is not satisfied, but the deadline epoch has been reached.
Checklist
- [ ] Commit sequence broadly makes sense and commits have useful messages
- [ ] New tests are added if needed and existing tests are updated. These may include:
- golden tests
- property tests
- roundtrip tests
- integration tests See Runnings tests for more details
- [ ] Any changes are noted in the
CHANGELOG.md
for affected package - [ ] The version bounds in
.cabal
files are updated - [ ] CI passes. See note on CI. The following CI checks are required:
- [ ] Code is linted with
hlint
. See.github/workflows/check-hlint.yml
to get thehlint
version - [ ] Code is formatted with
stylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
version - [ ] Code builds on Linux, MacOS and Windows for
ghc-8.10.7
andghc-9.2.7
- [ ] Code is linted with
- [ ] Self-reviewed the diff
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons. You will need to get someone with write privileges. Please contact IOG node developers to do this for you.