cardano-node icon indicating copy to clipboard operation
cardano-node copied to clipboard

[FR] - cardano-testnet: improve command line output format

Open klntsky opened this issue 1 year ago • 8 comments

External

Area Other

Describe the feature you'd like

We're considering replacing Plutip with cardano-testnet, and we'd like to see some changes upstream for our convenience.

  1. We'd like to make running the test suite optional, configurable via a CLI option. We really need faster startup times.
  2. We'd like to see more structured output (e.g. JSON) so that we can parse the TMP dir to get the node socket path, etc.

If we implement these changes in a PR, would it be considered for acceptance?

klntsky avatar May 20 '24 20:05 klntsky

cc @Jimbo4350 @carbolymer

smelc avatar May 21 '24 09:05 smelc

We'd like to make running the test suite optional, configurable via a CLI option. We really need faster startup times.

Actually, there are no tests executed when you're starting cardano-testnet using the cardano-testnet executable. It may appear so, because we're leveraging hedgehog's PropertyT when setting up the testnet nodes. So we're kind of abusing it to print debugging information by failing the test suite. All it does is starting the nodes and doing the healthcheck, so I think you won't get more speedup than it is right now (speaking about version in master).

We'd like to see more structured output (e.g. JSON) so that we can parse the TMP dir to get the node socket path, etc.

Definitely, if you feel that you can make the output both human readable and machine readable (by some toggle?) we'd be up for it.

If we implement these changes in a PR, would it be considered for acceptance?

Sure, if it won't be disruptive too much. It would be preferable if you could submit your changes in few smaller PRs.

carbolymer avatar May 22 '24 11:05 carbolymer

@carbolymer Thank you!

I have one more question: would it be possible for it to start instantly in the latest era, skipping the initial era transitions?

klntsky avatar May 22 '24 13:05 klntsky

That's supported already. In some of the test cases we're starting in Conway already, for example in here: https://github.com/IntersectMBO/cardano-node/blob/3d5df51000fbbf7492eba48f2bbc2472706abe17/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/ProposeNewConstitution.hs#L74

carbolymer avatar May 24 '24 09:05 carbolymer

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Jun 24 '24 01:06 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Feb 09 '25 01:02 github-actions[bot]

Related: https://github.com/IntersectMBO/cardano-node/issues/6080

smelc avatar Feb 11 '25 10:02 smelc

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Mar 16 '25 02:03 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Jun 19 '25 02:06 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Jul 24 '25 02:07 github-actions[bot]

This issue was closed because it has been stalled for 120 days with no activity. Remove stale label or comment or this will be closed in 60 days.

github-actions[bot] avatar Nov 23 '25 02:11 github-actions[bot]