cardano-node icon indicating copy to clipboard operation
cardano-node copied to clipboard

[FR] - make --port a config file parameter

Open gufmar opened this issue 1 year ago • 6 comments

External otherwise.

Area Other

Describe the feature you'd like same as the node config file already has port numbers for EKG and prometheus, the miniprotocol port should also become a configuration parameter in the config file.

Describe alternatives you've considered surrounding tools who want/need to know on which port the node runs, need manual (faulty) extra config values, or complicated ways to identify the cli startup parameter

Basically all command line parameters other than --config could become part of the config file

gufmar avatar Aug 29 '23 16:08 gufmar

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Sep 29 '23 01:09 github-actions[bot]

@Jimbo4350 , @CarlosLopezDeLara> how do we stand on this feature request?

smelc avatar Sep 29 '23 07:09 smelc

Hello @gufmar, cardano-node developer here :wave:

After some internal discussions, the team is not keen to add a configuration parameter in the config file, but we could add an environment variable override for this, in the same vein as CARDANO_NODE_SOCKET_PAH for cardano-cli. @gufmar> Would that improve your situation?

smelc avatar Oct 20 '23 07:10 smelc

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Nov 20 '23 01:11 github-actions[bot]

Ping @gufmar, did you see my question above?

smelc avatar Nov 20 '23 08:11 smelc

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Dec 21 '23 01:12 github-actions[bot]