cardano-ledger-byron icon indicating copy to clipboard operation
cardano-ledger-byron copied to clipboard

Published 20 hours ago • verified publisher icon input-output-hk

Functions without tests

Open erikd opened this issue 6 years ago • 1 comments

Found a number of functions that have zero tests:

Cardano.Chain.Update.ApplicationName.checkApplicationName
Cardano.Chain.Update.SoftwareVersion.checkSoftwareVersion
Cardano.Chain.Genesis.NonAvvmBalances.convertNonAvvmDataToBalances
Cardano.Chain.Block.Body.bodyTxs
Cardano.Chain.Block.Body.bodyWitnesses

These were probably pulled in as they are from the cardano-sl repo, but they should still have tests.

erikd avatar Feb 25 '19 02:02 erikd

It is likely that many of these will be deleted, but I agree that we should audit them and add tests for the ones that may stay

ruhatch avatar Mar 18 '19 13:03 ruhatch