cardano-base
cardano-base copied to clipboard
Perturbing/add msm bls
Description
Checklist
- [ ] Commit sequence broadly makes sense and commits have useful messages
- [ ] New tests are added if needed and existing tests are updated
- [ ] All visible changes are prepended to the latest section of a
CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md) - [ ] When applicable, versions are updated in
.cabalandCHANGELOG.mdfiles according to the versioning process. - [ ] The version bounds in
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md) - [ ] Commits that only contain large amounts of formatting changes were added to
.git-blame-ignore-revs - [ ] Self-reviewed the diff
Thank you for taking a first look @lehins, much appreciated!
The FFI is not working yet, I am getting some segmentation faults that I am trying to debug with valgrind.
Hi, I fixed the bug I encountered with the memory layout (I overlooked how C code wanted the pointer).
I also added a property test, but got some weird behavior where my test's success depends on the running of other tests. See my comments here and here.
@perturbing Could I ask you to cleanup the git commit history. Otherwise I am just gonna squash the whole 73 commits into one big one with very little info.
I think the above is too messy, since the impact of this PR is small, I made a new PR here #536. Closing this one!