cardano-base icon indicating copy to clipboard operation
cardano-base copied to clipboard

Perturbing/add msm bls

Open perturbing opened this issue 11 months ago • 2 comments
trafficstars

Description

Checklist

  • [ ] Commit sequence broadly makes sense and commits have useful messages
  • [ ] New tests are added if needed and existing tests are updated
  • [ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • [ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the versioning process.
  • [ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • [ ] Commits that only contain large amounts of formatting changes were added to .git-blame-ignore-revs
  • [ ] Self-reviewed the diff

perturbing avatar Nov 26 '24 08:11 perturbing

Thank you for taking a first look @lehins, much appreciated!

The FFI is not working yet, I am getting some segmentation faults that I am trying to debug with valgrind.

perturbing avatar Nov 27 '24 11:11 perturbing

Hi, I fixed the bug I encountered with the memory layout (I overlooked how C code wanted the pointer).

I also added a property test, but got some weird behavior where my test's success depends on the running of other tests. See my comments here and here.

perturbing avatar Jan 21 '25 14:01 perturbing

@perturbing Could I ask you to cleanup the git commit history. Otherwise I am just gonna squash the whole 73 commits into one big one with very little info.

lehins avatar May 30 '25 22:05 lehins

I think the above is too messy, since the impact of this PR is small, I made a new PR here #536. Closing this one!

perturbing avatar Jun 03 '25 09:06 perturbing