cardano-base

cardano-base copied to clipboard

Nix based GHAs for easy reproducibility and cross compilation.

1

This reuses our haskell.nix infrastructure through the input-output-hk/devx repository to build GHAs that effectively run ``` nix develop github:input-output-hk/devx#ghc-minimal-iog ``` (as well as JavaScript and Windows cross). This is distinctly...

angerman

KES Agent prerequisites

1

Adds: - **Direct serialization/deserialization of KES sign keys:** we need this in order to send keys over network sockets without touching the GHC heap (which would violate mlocking protections). -...

tdammers

Currently `EpochInfo` is datatype consisting of bunch of closures, parametrized by monad. Such datatype cannot be prettyprinted, serialized or otherwise inspected both in Haskell or by developer. Thus some libraries...

uhbif19

https://github.com/input-output-hk/cardano-base/actions/runs/5953821210/job/16148970273?pr=433 shows a test failure related to `SchnorrSecp256k1` on MacOS with `ghc-8.10.7`: ```text SchnorrSecp256k1 Signing and verifications should be successful.: OK Verification only should be successful.: FAIL src/Test/Crypto/Vector/Secp256k1DSIGN.hs:330: Test failed....

jorisdral

Originally reported in https://github.com/input-output-hk/cardano-base/pull/429#issuecomment-1660356665 I've seen this on a couple of occasions, but only on Windows CI. ``` NoThunks VerKey: OK (8.87s) +++ OK, passed 1000 tests. SignKey: OK (0.24s)...

lehins

Hi, I can't seem to build cardano-crypto-class in plain nix (not haskell.nix), due to the cbits library. I have a cabal2nix expression for cardano-crypto-class and am overriding it with addPkgconfigDepends...

locallycompact

Inconsisent exports in `blst` bindings.

1

`Cardano.Crypto.EllipticCurve.BLS12_381.Internal` [exports](https://github.com/input-output-hk/cardano-base/blob/a344b32d97b0d0e83b773069f6a20f7e5fa67478/cardano-crypto-class/src/Cardano/Crypto/EllipticCurve/BLS12_381/Internal.hs#L147C16-L147C16) both `blsGenerator` and `blsZero`, but the main public interface in `Cardano.Crypto.EllipticCurve.BLS12_381` [exports only blsGenerator](https://github.com/input-output-hk/cardano-base/blob/a344b32d97b0d0e83b773069f6a20f7e5fa67478/cardano-crypto-class/src/Cardano/Crypto/EllipticCurve/BLS12_381.hs#L30). Perhaps it should export `blsZero` as well for consistency.

kwxm

As mentioned in https://github.com/input-output-hk/cardano-base/pull/365, some packaging problems currently go undetected in CI. Proposed fix: add an "sdist" step to the Haskell workflow, which runs `cabal sdist all` - this command...

tdammers

Similar to key and seed sizes, define `TotalPeriodsKES` as a type-level `Nat`, and implement term-level `totalPeriodsKES` in terms of `natVal`.

tdammers

Usage of `assert`s

1

There are a few places in KES implementation where `Control.Exception.assert` is being used. This has no affect since `assert`s will never get triggered, because they are removed by the compiler,...

lehins