scrumlr.io icon indicating copy to clipboard operation
scrumlr.io copied to clipboard

chore: removal of note observer

Open BenedictHomuth opened this issue 10 months ago • 3 comments

Description

This PR removes only the observers for notes. It is meant for a proof of concept before removing the remaining observers.

In order to test, I needed to mock the real-time broker (which includes its client aka. the con field). Before I could not create a Mock-Broker, since the "con" field was not exported. With the changes at hand, I now export the "Con" field, which makes it possible to mock out the broker ultimately leading to running tests 🙂.

Changelog

  • Removed the note observers
  • Moved the observer logic inside the service layer
  • Made the general code work with those changes
  • Exported the Con field of real-time broker in order to be able to mock the real-time package
  • Adapted tests to run without observers

Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] The light- and dark-theme are both supported and tested
  • [ ] The design was implemented and is responsive for all devices and screen sizes
  • [ ] The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

BenedictHomuth avatar Apr 05 '24 21:04 BenedictHomuth

🐙 Octomind

Test Report: 0/13 successful.

description status details
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 97a849d

octomind-dev[bot] avatar Apr 05 '24 21:04 octomind-dev[bot]

The deployment to the dev cluster was successful. You can find the deployment here: https://4046.development.scrumlr.fra.ics.inovex.io This deployment is only for testing purposes and will be deleted after 1 week. To redeploy rerun the workflow. DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-efe14f6

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-efe14f6

github-actions[bot] avatar Apr 30 '24 14:04 github-actions[bot]

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: efe14f6

octomind-dev[bot] avatar Apr 30 '24 14:04 octomind-dev[bot]