scrumlr.io icon indicating copy to clipboard operation
scrumlr.io copied to clipboard

improvement: revised icons

Open b8daniel opened this issue 11 months ago • 3 comments

Description

  • #3268 The icons with the updated design from Figma need to be imported and updated in code.

Changelog

  • created a script to generate a index.ts file that exports all icons as named react components
  • edit the svg by renaming the white color to currentColor and adding a class of icon
  • added default styling for icons
  • checked & updated styling (see all .scss files changed)
  • updated the snapshots

Checklist

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] The light- and dark-theme are both supported and tested
  • [x] The design was implemented and is responsive for all devices and screen sizes
  • [x] The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

full table of icon changes

b8daniel avatar Mar 15 '24 23:03 b8daniel

Hey @blxckOxymoron, thank you for your huge contribution! Your changes look great and really helpful. Is it still work in progress or can it already be reviewed?

brandstetterm avatar Mar 26 '24 12:03 brandstetterm

Thank you for taking a look, It's not 100% finished yet, since I need to check some more components for any style issues caused by the change. I also found that some icons haven't been updated yet, as listed in the issue. When these are updated soon, they could be included in this PR as well.

Furthermore I'm unfortunately unable to work on this untill 05.04., but I will finish it when I'm back.

b8daniel avatar Mar 26 '24 15:03 b8daniel

I have finished looking through the places where the icons have changed. There is now also a table attached, which lists all icons and how I tried to replace them.

b8daniel avatar Apr 04 '24 21:04 b8daniel

Thank you very much for your contribution @blxckOxymoron! Sorry that it took a while for your pull request to be merged

brandstetterm avatar Jun 15 '24 07:06 brandstetterm