scrumlr.io icon indicating copy to clipboard operation
scrumlr.io copied to clipboard

Published 20 hours ago • verified publisher icon inovex

feat: lock board

Open brandstetterm opened this issue 11 months ago • 25 comments

Description

Frontend changes related to the locking of a board. If a board is locked, participants (without moderation permissions) are no longer able to create, update and delete notes, dispatch board reactions, add or remove reactions to a note, add or remove votes to a note. Therefore, there have been some changes in the frontend (e.g. gray out buttons, hide buttons, etc.). A detailed list of the changes can be found below.

Closes #3538

Changelog

  • NoteInput: Disable textarea, add lock icon, gray out plus icon
  • StackView: Disable textarea to edit note content, hide delete and unstack buttons
  • Action Bars: Disable button to dispatch board reactions, automatically close board reactions menu if board gets locked
  • Notes: Hide button to open reactions dropdown, disable button to remove note reactions, hide button to add a vote and disable button to remove a vote
  • Update several tests and snapshots

Future tasks

  • Implement notifications manager and dispatch notification that board is locked on join

Visual changes

Screenshot 2024-03-18 at 17 31 49 Screenshot 2024-03-18 at 17 32 05

brandstetterm avatar Mar 08 '24 09:03 brandstetterm

🐙 Octomind

Test Report: 10/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 2fffed9

octomind-dev[bot] avatar Mar 11 '24 08:03 octomind-dev[bot]

🐙 Octomind

Test Report: 12/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 7af6b86

octomind-dev[bot] avatar Mar 11 '24 10:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 7b6091e

octomind-dev[bot] avatar Mar 12 '24 12:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Failed ❌ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 315cf92

octomind-dev[bot] avatar Mar 12 '24 13:03 octomind-dev[bot]

🐙 Octomind

Test Report: 12/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: a18c165

octomind-dev[bot] avatar Mar 12 '24 13:03 octomind-dev[bot]

🐙 Octomind

Test Report: 12/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 8667426

octomind-dev[bot] avatar Mar 15 '24 10:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: f22d02a

octomind-dev[bot] avatar Mar 15 '24 11:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Failed ❌ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 57b2061

octomind-dev[bot] avatar Mar 18 '24 08:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: bbd9495

octomind-dev[bot] avatar Mar 18 '24 09:03 octomind-dev[bot]

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: b398733

octomind-dev[bot] avatar Mar 18 '24 13:03 octomind-dev[bot]

🐙 Octomind

Test Report: 12/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: ae7f665

octomind-dev[bot] avatar Mar 18 '24 15:03 octomind-dev[bot]

🐙 Octomind

Test Report: 10/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: b288bc6

octomind-dev[bot] avatar Mar 18 '24 16:03 octomind-dev[bot]

🐙 Octomind

Test Report: 10/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 860d49b

octomind-dev[bot] avatar Mar 20 '24 11:03 octomind-dev[bot]

Added a blocked label, because #4104 should be merged before this

Schwehn42 avatar Apr 27 '24 12:04 Schwehn42

Thanks for your review @Schwehn42 Since I'm limited in time right now, you can commit the suggested changes yourself if you want 😄

brandstetterm avatar Apr 30 '24 17:04 brandstetterm

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 34cf2e3

octomind-dev[bot] avatar May 06 '24 11:05 octomind-dev[bot]

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 9f6ba11

octomind-dev[bot] avatar May 07 '24 16:05 octomind-dev[bot]

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 0ed8a50

octomind-dev[bot] avatar May 13 '24 14:05 octomind-dev[bot]

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Error 💔 click
test all ways to open the setup flow Failed ❌ click

commit sha: ffcadc6

octomind-dev[bot] avatar May 14 '24 10:05 octomind-dev[bot]

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: f353a3d

octomind-dev[bot] avatar May 29 '24 12:05 octomind-dev[bot]

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: f353a3d

octomind-dev[bot] avatar May 29 '24 12:05 octomind-dev[bot]

added feats: #4144 and #4145, ready to review now

Schwehn42 avatar May 29 '24 15:05 Schwehn42

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: d9e20ed

octomind-dev[bot] avatar Jun 17 '24 14:06 octomind-dev[bot]

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: b365700

octomind-dev[bot] avatar Jun 26 '24 10:06 octomind-dev[bot]

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Failed ❌ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 257d80b

octomind-dev[bot] avatar Jul 16 '24 15:07 octomind-dev[bot]

Should the feature of locking a board also be an option, when creating a board? Meaning that it should be possible to set the "isLocked" field in the API request when creating a board?

If so I would add it. I do not remember if this was requested or not when we formulated this feature.

BenedictHomuth avatar Jul 19 '24 09:07 BenedictHomuth

@BenedictHomuth

Should the feature of locking a board also be an option, when creating a board?

This isn't an AC in #3538, so I would hold on implementing it, since the create board screen will be overhauled soon anyways.

Schwehn42 avatar Jul 19 '24 11:07 Schwehn42

@laila-rin Good point, I actually like the initial idea from the issue (#3538) where instead of toggle in board settings, it would be an button on the right where the rest of the moderator tools (start vote, start timer ...) are. That way, moderators could always see whether it's active, and also toggle it with one click instead of two.

What do you think about this? Also, does it make more sense to just use this version and make these changes in a new PR, if @SelinaBuff approves of the idea?

Schwehn42 avatar Jul 19 '24 14:07 Schwehn42

The deployment to the dev cluster was successful. You can find the deployment here: https://3955.development.scrumlr.fra.ics.inovex.io This deployment is only for testing purposes and will be deleted after 1 week. To redeploy rerun the workflow. DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-d789bd8

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-d789bd8

github-actions[bot] avatar Jul 19 '24 14:07 github-actions[bot]

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: d789bd8

octomind-dev[bot] avatar Jul 19 '24 14:07 octomind-dev[bot]