scrumlr.io icon indicating copy to clipboard operation
scrumlr.io copied to clipboard

improvement: Removal of observers

Open BenedictHomuth opened this issue 1 year ago • 3 comments

Description

This PR removes all currently used observers. The logic is moved back inside the corresponding service packages.

The column observer is left out, since it is covered in (https://github.com/inovex/scrumlr.io/pull/3400)

Changelog

Removed all observer and corresponding test files.

After every qualified DB transaction, the websocket messages are now published in an asynchronous go-routine.

Checklist

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [] The light- and dark-theme are both supported and tested
  • [] The design was implemented and is responsive for all devices and screen sizes
  • [x] The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

BenedictHomuth avatar Oct 10 '23 18:10 BenedictHomuth

🐙 Octomind

Test Report: 6/9 successful.

description status details
change avatar Passed ✅ click
sign-in Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
share_session Passed ✅ click
sign-in with Google - incomplete test Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
test all ways to open the setup flow Passed ✅ click
create and delete board columns Failed ❌ click

commit sha: 90f540f

octomind-dev[bot] avatar Jan 09 '24 16:01 octomind-dev[bot]

The deployment to the dev cluster was successful. You can find the deployment here: https://3458.development.scrumlr.fra.ics.inovex.io This deployment is only for testing purposes and will be deleted after 1 week. To redeploy rerun the workflow. DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-c4a8988

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-c4a8988

github-actions[bot] avatar Jan 11 '24 16:01 github-actions[bot]

🐙 Octomind

Test Report: 6/9 successful.

description status details
change avatar Passed ✅ click
sign-in Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
share_session Passed ✅ click
sign-in with Google - incomplete test Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
test all ways to open the setup flow Passed ✅ click
create and delete board columns Failed ❌ click

commit sha: c4a8988

octomind-dev[bot] avatar Jan 11 '24 16:01 octomind-dev[bot]