scrumlr.io icon indicating copy to clipboard operation
scrumlr.io copied to clipboard

Published 20 hours ago • verified publisher icon inovex

Toast message is not visible in dark mode.

Open Quasilius-Starlord opened this issue 1 year ago • 3 comments

Problem description

Text in toast messages those pop-up when notes on a board are deleted aren't visible in dark mode. This is an issue with the contrast ratio of toast message text and its background. Although aforementioned behavior isn't seen in light mode. bug_toast_message

Browser

Chrome

Steps to reproduce the behavior

  • Create a new board.
  • Create a note.
  • Delete the note and notice the toast message that appear in lower right part of your screen doesn't have any readable text.

Screenshots

bug_toast_message

Additional context

No response

Quasilius-Starlord avatar Oct 07 '23 19:10 Quasilius-Starlord

I've noticed this in firefox as well, the border radius is also wrong

this is caused by the lack of support for the css :has() selector. similar to #3048 we need to see how much of a workaround would be needed

looking at https://caniuse.com/css-has, the feature is suported in 87% of browsers with firefox being the only browser that doesen't support it in their latest version

b8daniel avatar Oct 09 '23 08:10 b8daniel

found it: https://github.com/inovex/scrumlr.io/blob/7dc3b5f7a76cb773d89dceaf53a9ceb53f2c81e2/src/components/CustomToast/CustomToast.scss#L307-L310 but I think the :has maybe isn't even necessary here

b8daniel avatar Oct 09 '23 08:10 b8daniel

Thank you for your bug report @Quasilius-Starlord. Currently I cannot reproduce the bug. It may have already been fixed by one of our changes. The toast that is displayed for me in the Chrome browser when I delete a note is as follows: scrumlr io_board_c797dd59-e1e4-45bd-9929-f755e0cd41af

Can you check if you are still experiencing the bug?

brandstetterm avatar Jan 02 '24 10:01 brandstetterm