elements icon indicating copy to clipboard operation
elements copied to clipboard

test(storybook): add snapshot tests

Open janivo opened this issue 3 years ago • 1 comments

Closes #713

  • add snapshot test for all stories

⚠️ ~~currently blocked by https://github.com/storybookjs/test-runner/issues/68#issuecomment-1214989696~~

janivo avatar Aug 15 '22 13:08 janivo

Seems to be fixed for now. Probably some weird dependency errors.

But there is still one problem: In some of our components we generate random IDs which lead to following errors:

    -       <label for="ino-switch-id__4h67rw409">
    +       <label for="ino-switch-id__8g9ktqkwt">

We need to think about how we want to handle these cases. IDs are necessary for <label> elements.

Proposals:

  • Mock the function that generates the ID's (preferred but might be hard, as only the dist of the core packages is available)
  • Add a 'hidden' property/data-attribute to pass an ID to the respective components

janivo avatar Aug 18 '22 11:08 janivo

closed for now because of flakiness

janivo avatar Mar 16 '23 16:03 janivo