slack-bot icon indicating copy to clipboard operation
slack-bot copied to clipboard

Interaction with cloud(AWS) serverless function proposal

Open joosangkim opened this issue 3 years ago • 2 comments

Hi @brainexe 😄
It's been a while.

My latest contribution to innogames slack bot is interaction with aws cloudfront. We'd discussed about how to make the slack bot working with flexibly with other aws's product or other vendors.

My proposal is invoking lambda - in aws case - which works specific functions. For example, in my commit, you can define multiple lambda functions in aws.yaml configuration file. The slack bot can invoke each lambda function with specific inputs via slack modal view.

Also some teams wants use their own command to invoke it, so I added command alias functionality.

Thanks for reviewing my PR 😄

joosangkim avatar Jul 14 '22 02:07 joosangkim

Codecov Report

Merging #330 (8d5605f) into master (c4410de) will decrease coverage by 1.14%. The diff coverage is 22.33%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   84.42%   83.27%   -1.15%     
==========================================
  Files         113      113              
  Lines        4892     5005     +113     
==========================================
+ Hits         4130     4168      +38     
- Misses        670      746      +76     
+ Partials       92       91       -1     
Impacted Files Coverage Δ
bot/config/aws.go 100.00% <ø> (ø)
bot/msg/ref.go 94.28% <0.00%> (-5.72%) :arrow_down:
client/cloud/aws/client.go 0.00% <0.00%> (ø)
client/slack.go 73.36% <0.00%> (-2.85%) :arrow_down:
command/clouds/aws/commands.go 28.57% <0.00%> (+10.38%) :arrow_up:
command/clouds/aws/lambda.go 0.00% <0.00%> (ø)
bot/bot.go 82.08% <100.00%> (+0.86%) :arrow_up:
bot/interaction.go 91.40% <100.00%> (+3.36%) :arrow_up:
bot/listener.go 50.00% <0.00%> (-10.00%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 14 '22 02:07 codecov-commenter

The lint test failed now because I changed https://github.com/innogames/slack-bot/blob/master/bot/interaction.go#L54 this function to switch case with slack payload.Type to handle with modal view payload.

joosangkim avatar Jul 14 '22 02:07 joosangkim