pantab icon indicating copy to clipboard operation
pantab copied to clipboard

Edit on github in docs link is broken

Open paddymul opened this issue 1 year ago • 2 comments

Describe the bug The edit on github link on the docs site is broken

Instead of linking to https://github.com/innobi/pantab it links to https://github.com///blob/index.rst

To Reproduce Go to https://pantab.readthedocs.io/en/latest/index.html click on the "edit on github" link on thr top right corner

<INSERT_STEPS_HERE>

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]

Additional context Add any other context about the problem here.

paddymul avatar Oct 25 '24 02:10 paddymul

I looked at the code including doc/conf.py and didn't see where that link comes from. Maybe the default sphinx feed reads from something in pyproject.toml, but I'm not sure.

paddymul avatar Oct 25 '24 02:10 paddymul

Hmm OK. May have been broken a while back and no one noticed - PRs to fix are always welcome!

WillAyd avatar Oct 25 '24 12:10 WillAyd

Hello @WillAyd , I'd like to work on fixing this. Could you please assign?

Priyansh121096 avatar Oct 05 '25 12:10 Priyansh121096

@WillAyd @jorwoods I've raised https://github.com/innobi/pantab/pull/409 for this. I've tested locally that the configuration changes do fix the issue.

Priyansh121096 avatar Oct 05 '25 12:10 Priyansh121096