image-picker icon indicating copy to clipboard operation
image-picker copied to clipboard

App Crash because of memory warning

Open imbaggaarm opened this issue 5 years ago • 3 comments

Hi, I recently find out a bug, when collection view loads a lot of images, app will crash, can you fix that problem. Thank you. Btw, your library is really great, but can you detail more about How to install it via carthage, or pod, and manually too. Thanks.

imbaggaarm avatar Jul 23 '18 13:07 imbaggaarm

@imbaggaarm Thank you for your support and finding out new bug.

Can you please approx. specify the amount of photos you use to test the issue? To answer the second part:

For cocoapods - we do not support cocoapods yet - I will file an improvement for it.

For carthage setup Carthage as usually and add github "inloop/image-picker" to your cartfile. If you would like to specify branch, just use github "inloop/image-picker" "master". We will definitely look into the memory issue.

radimhalfar avatar Jul 23 '18 16:07 radimhalfar

About 1540 photos, I think we should delete some photos were loaded when scroll up or down, that will fix the problem.

imbaggaarm avatar Jul 24 '18 09:07 imbaggaarm

I was able to reproduce this. It looks like when you scroll rapidly app can allocate too much memory at once and system does not release it quickly enough. This should be definitely fixed.

tankista avatar Sep 20 '18 15:09 tankista