inkstitch icon indicating copy to clipboard operation
inkstitch copied to clipboard

cvick32/pdf pattern only

Open cvick32 opened this issue 2 years ago • 1 comments

cvick32 avatar Sep 30 '22 19:09 cvick32

For description and discussion about this pull request see #1759

I just had a look at it and have an other change request. It's about the settings window:

The "show footer" option only applies to the "full page pattern view" and I think this should be visually represented in the settings window through a text-indent. Same goes for the thumbail size setting which is now somehow detached from the operator detailed view (to which it applies). So it should be moved up to appear directly underneath it.

kaalleen avatar Oct 01 '22 07:10 kaalleen

@cvick32 I approved your changes.

We had a bug in the custom information sheet that the text didn't find it's way into the print out. So I pushed a fix into your branch while doing the above requested changes myself. I hope that's ok with you.

You can merge this branch into main, when you feel this is ready.

kaalleen avatar Oct 15 '22 15:10 kaalleen