inky icon indicating copy to clipboard operation
inky copied to clipboard

Use Electron-Builder to Create the Build Artifacts (Installers)

Open lunarcloud opened this issue 3 years ago • 4 comments

Much of what #181 was concerned about were installers and signing - all things that using Electron-Builder would enable.

I've started the work in a branch: https://github.com/lunarcloud/inky/tree/electron-builder

But I'm not sure if I have the time right now to fully-test it yet.

lunarcloud avatar Jun 20 '22 02:06 lunarcloud

To be clear: This seems to work awesomely - at least on Linux, I'm seeing no problems with the 1 commit ( https://github.com/inkle/inky/commit/d5604daaf2d7877b1ddffb59a9304f158028cf8c )

lunarcloud avatar Jun 20 '22 02:06 lunarcloud

Interesting. Will it require an update of Electron, or will it still work on any version of Electron?

GreenCloversGames avatar Jun 26 '22 19:06 GreenCloversGames

Interesting. Will it require an update of Electron, or will it still work on any version of Electron?

No change, left that untouched.

lunarcloud avatar Jun 26 '22 21:06 lunarcloud

FYI, the only reason this hasn't been pull-requested is because the one non-"binaries in a zip" release, the mac DMG, might not be on-par with what's already built today. And I don't have a mac right now to test/develop with to make that happen.

lunarcloud avatar Aug 04 '22 17:08 lunarcloud