inky icon indicating copy to clipboard operation
inky copied to clipboard

Cannot close or save the project when one of the ink files is empty.

Open ievgennaida opened this issue 5 years ago • 3 comments

  1. Add new ink file. Change main ink file.

Cannot close the application, while file data cannot be saved.

ievgennaida avatar Jun 02 '19 23:06 ievgennaida

This is known. If any file in the project is blank inky can’t save. Adding any character to the new ink file will allow saving. (It’s on our radar but we haven’t had a moment to fix it!)

Jazz, in Three-Four Time: A Novel http://www.amazon.co.uk/dp/B004K1EYIE

joningold avatar Jun 03 '19 06:06 joningold

As a follow-up to the "Don't save blank files in your project or you will lose your work." issue:

This has happened enough to unsuspecting users, and is disastrous enough (irrecoverable loss of work, not signposted in anyway) that I'm wondering if a hotfix might be a good idea, in lieu of the resources necessary to chase this bug up properly.

Instantiating all automatically created Ink files with a placeholder comment is my suggested solution.

https://github.com/inkle/inky/pull/231

Liance avatar Mar 22 '20 19:03 Liance

There is still an issue saving the content of new ink files in Inky. This is a bug which occurs in the most recent version of the master branch, and can be reproduced in two ways:

Reproduce bug:

  1. Create a file ink file in Inky with "Add new include" at the bottom left of the Inky app.
  2. Replace the placeholder text with some other text, like a valid knot stub.
  3. Save the file
  4. Open another file and then open your new file again.

Result: You see the placeholder text in the file again.

Reproduce bug:

  1. Create a file ink file in Inky with "Add new include" at the bottom left of the Inky app.
  2. Replace the placeholder text with some other text, like a valid knot stub.
  3. Save the file
  4. Close Ink

Result: You are prompted to save changes before exiting. a. When pressing Save, the dialog box closes, but not the Inky app. When pressing Don't save, the app closes. b. When reopening the ink project in Inky again, the content of the file is now only the placeholder text again.

This bug can be avoided or worked around by saving a new file with Ctrl+S without changing its placeholder, just after adding this new file to the project. Then you can do changes safely. You still get a saving prompt when trying to close the Ink app. You then have to press "Don't save" to close, but the changes of the new file are not lost.

I have created an own issue for this, after doing some more testing. My issue seems to be related to the "Add to main ink" checkbox" in the "Enter new ink file name" section below the file hierarchy: #304

Targeir-Attestog avatar Dec 15 '20 23:12 Targeir-Attestog