ink icon indicating copy to clipboard operation
ink copied to clipboard

[1.1] Tag in choice appearing in choice text

Open smwhr opened this issue 2 years ago • 1 comments

The tag in a choice appears inside of the choice text.

Minimal ink to reproduce :

* a choice # a tag 
    the result

Reproducible evidence :

image

Expected behaviou : a tag should not appear in choice.text but rather in choice.tags

smwhr avatar Oct 19 '22 15:10 smwhr

Yep, we've been finding a couple of bugs like this... apologies I don't think I tested thoroughly enough! We're going to have to put out a replacement 0.0.1 update.

You guys might want to hold off on the inkjs porting until I'm done!

joethephish avatar Oct 19 '22 16:10 joethephish

Caught by our test suite, i thought the bug was on our side :)

Porting of the runtime is almost done, it'll ease porting your subsequent commits if it touches it.

smwhr avatar Oct 19 '22 16:10 smwhr

Just pushed a commit to master that’s 95% of the way there (I think/hope!) and has required fairly significant re-engineering of the way this feature works.

There’s a case where I’ve managed to crash though it so just looking into that…

joethephish avatar Oct 19 '22 16:10 joethephish

Great work @joethephish !

smwhr avatar Oct 20 '22 05:10 smwhr

Thanks, fixed!

joethephish avatar Oct 20 '22 10:10 joethephish