Leandro López
Leandro López
Thank you @SuperQ!
Oh this would be so nice to have! @cpaloia @X-Guardian is there anything that could be done to get this merged?
> Not too sure if you are aware, but using `-memprofile`, you can also generate a profile of your micro benchmark to see how it performs line by line: (left...
@simonswine applying your changes to the benchmark it runs ~13% faster with the original code, so I'm going to reorder the commits and run the benchmarks again to get more...
I've found another thing that could be pre-initialized with a size that greatly affects the performance, and is the `*deduplicatingSlice.lookup` map (see [here](https://github.com/inkel/pyroscope/blob/inkel/deduplicating-slice-ingest-improvements/pkg/phlaredb/symdb/dedup_slice.go#L242-L244)), however, that one is trickier to address...
🤔 there's a failing test on CI, IIUC due to a context cancelled. I've run `make go/test` locally and it's working, maybe it needs to re-run?
No worries!
@simonswine 👋🏽 any updates that I need to make to this? Last time CI failed because there were some flaky tests.
Thank you for the review and suggestions!! And I'll definitely be looking at those graphs 😬