cordova-plugin-themeablebrowser icon indicating copy to clipboard operation
cordova-plugin-themeablebrowser copied to clipboard
verified publisher icon initialxy

UPDATE SOURCE CODE: Merged Repository (for those interested)

Open grexican opened this issue 6 years ago • 5 comments

I have merged in most of the PRs on this branch. I'm still testing, so I haven't merged everything into the master branch yet. But if anyone wants to try things out: cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

When I merge things back into the main branch, I will let everyone know.

grexican avatar Feb 12 '19 15:02 grexican

Can you also include #71 along with this.

anotherapj avatar Mar 13 '19 14:03 anotherapj

Done.

grexican avatar Mar 14 '19 10:03 grexican

cordova plugin add https://github.com/grexican/cordova-plugin-themeablebrowser.git#patches

@grexican Thank you for the efforts. There is an error at installation: Using "requireCordovaModule" to load non-cordova module "glob" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.

When running on iOS, it encountered an error: Property 'getCurrentURL' not found on object of type 'CDVThemeableBrowserViewController *'; did you mean 'currentURL'?

visortown avatar Mar 31 '19 23:03 visortown

@visortown hmmm ok I'll take a look and get 'er running. No merge conflicts before so I took it for granted that it was good to go.

grexican avatar Apr 02 '19 11:04 grexican

@grexican very perfect！Thank you for your contribution！

hooliy avatar Jul 16 '19 14:07 hooliy