Refactor context usage and keeper calls

[Fallengirl]

Refactor context usage and keeper calls for consistency and clarity. Replaced direct or duplicate contexts, streamlined keeper method calls, and removed unused variables. This improves maintainability and aligns with best practices.

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

This pull request refactors various modules to replace indirect method calls through embedded fields (typically the Keeper field) with direct calls on their respective struct instances. Additionally, some if-else control flows have been streamlined into switch-case constructs and minor conditional logic adjustments have been made. These changes improve code clarity and maintainability without altering external interfaces or introducing new functionality.

Changes

Files	Change Summary
app/app.go, app/export.go	Replaced indirect GRPC and consensus method calls (using BaseApp/Keeper) with direct instance methods; simplified genesis preparation logic.
crypto/ledger/usbwallet/wallet.go	Refactored conditional checks in SignData by switching to simplified inequality comparisons for improved readability.
x/bank/keeper/custom_msg_server.go x/distribution/keeper/custom_grpc_query.go x/distribution/keeper/grpc_query.go x/gov/abci.go x/gov/keeper/custom_grpc_query.go x/gov/keeper/msg_server.go x/ibc/perm/keeper/grpc_query.go x/ibc/perm/keeper/msg_server.go	Removed indirection by replacing calls on embedded Keeper with direct calls on the instance; updated conditional logic in gov modules.
x/dynamic-fee/keeper/ante.go	Modified access to baseDenomKeeper and tokenPriceKeeper by removing the unnecessary Keeper prefix.
x/move/client/cli/utils.go x/move/keeper/api.go x/move/keeper/balancer.go x/move/keeper/keeper.go x/move/keeper/msg_server.go x/move/keeper/querier.go x/move/keeper/vesting.go	Refactored multiple Move module methods by replacing indirect calls (via Keeper) with direct calls; refactored conditionals into switch-case statements for clearer logic.
x/mstaking/keeper/compatibility_keeper.go x/mstaking/keeper/grpc_query.go x/mstaking/keeper/msg_server.go	Updated method calls and variable references to use direct instance access, thereby streamlining validator, delegation, and address codec queries.

Possibly related PRs

• initia-labs/initia#289: Involves similar modifications in the InitiaApp struct’s service registration methods by altering GRPC query router accesses.
• initia-labs/initia#194: Focuses on simplifying method calls within the Querier struct in the mstaking module, showing direct relevance in terms of code refactoring.

Suggested reviewers

• sh-cha
• beer-1

Poem

I hop through lines with a skip and a bound,
Trimming the calls where indirections were found.
Switches now sing in a cleaner array,
Code paths clearer by the light of day.
With each little refactor, my heart goes leap—
A rabbit’s delight in code so deep! 🐰

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[beer-1]

Thanks for PR, but we are not accepting style update PRs 🙏