inikep
Hardcode Lizard compression level
Remove compilation errors in builds without Lizard by hardcoding its minimum and maximum compression levels.
I initially considered using #ifdef, but later realized that the table doesn’t follow that approach.
Hi, what compilation error do you see? I compiled lzbench with
make CC=gcc-14 CXX=g++-14 -j40 CUDA_BASE="" DONT_BUILD_LIZARD=1
and compilation was fine without lizard. I verified it looking at codecs list: lzbench -l.
Did you remove lzbench directory?
Hey Przemysław, I should’ve clarified a bit more. I didn’t remove the folder itself - I set up the CMake-based build with the goal of building and running it on Windows. If I get the chance to finalize it, I’d be happy to contribute further. While working on it, I noticed that some variables aren’t properly guarded when DONT_BUILD_LIZARD is defined, so I created a pull request to address that. That said, if you don’t find the change valuable, I’m totally fine with the PR being rejected.
You could put that 'cmakefile' in a gist, so one could get and test it, to see what is the actual problem.
You could also fork and brach the repository, and put there cmakefile, along with ci-test in gh action, so everytime you pushed a change, it would be tested. There you would be able to see the logs and point to the errors.
@stima Please contribute your CMake for lzbench. It should be helpful for many people.