lzbench icon indicating copy to clipboard operation
lzbench copied to clipboard

Add ppmd based on LZMA SDK 22.01 (thanks to @pps83)

Open pps83 opened this issue 3 years ago • 4 comments

pps83 avatar Jan 11 '23 20:01 pps83

sounds stupid to say thanks to @myself, I simply based entire PR on some other diff that added another codec

pps83 avatar Jan 11 '23 20:01 pps83

All those functions ( pmalloc(), pfree(), CharWriter, CharWriterFunc() ) should be moved to lzbench_ppmd_compress(). They are small enough to move to the function body. Compressors.cpp is not private yard, it's public space and you should not litter it.

tansy avatar Oct 14 '23 20:10 tansy

@tansy sorry for late reply. PR updated.

pps83 avatar Dec 21 '23 23:12 pps83

FYI, when I tried to use latest LZMA SDK 23.01 (instead of 22.01) I got compilation errors because lzbench already contains older lzma sdk parts (specifically 7zTypes.h, Compiler.h, Precomp.h and others are conflicting). With 22.01 at least it compiles cleanly.

when lzma is updated to 23.01, libppmd should also be updated to 23.01 at the same time

FYI @inikep

pps83 avatar Dec 22 '23 00:12 pps83