ITU-Rpy icon indicating copy to clipboard operation
ITU-Rpy copied to clipboard

[BUG] unit mismatch in scintillation_attenuation_sigma

Open vianneylan opened this issue 6 months ago • 0 comments

Describe the bug in scintillation_attenuation_sigma method from itu618, there are two options for computing N_wet First one is as per ITU-R 453 (from T, P, H) second one is as per ITU monthly/annual maps from ITU-R 453 as well. However, second method gives N_wet in ppm (see https://www.itu.int/dms_pubrec/itu-r/rec/p/R-REC-P.453-14-201908-I!!PDF-E.pdf first line of section 2.2), while the first method give not ppm but direct ratio (i.e there is a 1e6 mismtach)

To Reproduce

second method does

map_wet_term_radio_refractivity(0, 90, 50).value # yields 128.

first method does (std parameters for T, P, and 90% humidity for H since over ocean

e = water_vapour_pressure(20., 1013., 90.).value wet_term_radio_refractivity(e, 20.).value # yields 9.74e-5 (understood as 97ppm which is ok, but missing a 1e6 scale factor)

Expected behavior when looking at Eq 4. of ITU-R 453 doc and comparing with method wet_term_radio_refractivity, there is a '1e-6' term that has been added in the latter. From ITu-R 618 https://www.itu.int/dms_pubrec/itu-r/rec/p/R-REC-P.618-14-202308-I!!PDF-F.pdf equation 42 I think N_wet is expected in ppm, so the above mentioned 1e-6 term should be removed

Additional context fix: removen the 1e-6 factor line 148 of file itur/models/itu453.py

vianneylan avatar Jun 18 '25 08:06 vianneylan