extended-enum icon indicating copy to clipboard operation
extended-enum copied to clipboard

Fix README typos

Open inhibitor1217 opened this issue 2 years ago • 4 comments

Spotted some typos in the code and plain text.. should fix them

inhibitor1217 avatar Dec 11 '21 15:12 inhibitor1217

Matches

extended enumerations provide a default method named is. is is aware of the primitives defining the enumeration.

enum _Fruit {
  Apple = 'APPLE',
  Orange = 'ORANGE',
}
const Fruit = extend<typeof _Fruit, Fruit>(Fruit);

const Fruit = extend<typeof _Fruit, Fruit>(Fruit); should be const Fruit = extend<typeof _Fruit, _Fruit>(_Fruit);

inhibitor1217 avatar Dec 11 '21 15:12 inhibitor1217

The exhuastive typing of union is not supported yet

should be

The exhaustive typing of union is not supported yet

inhibitor1217 avatar Dec 11 '21 15:12 inhibitor1217

I think there is a typo at what-powers-does-it-have.

expect(Animal.Cat !== Animal.Dog).toBe(false);

I think this should be corrected to either one of below, if it was supposed to describe that extended enum works like original TS enums when the are compared.

expect(Animal.Cat !== Animal.Cat).toBe(false);
expect(Animal.Cat !== Animal.Dog).toBe(true);
expect(Animal.Cat === Animal.Dog).toBe(false);

jirheee avatar Dec 12 '21 16:12 jirheee

Typos until this comment are corrected in #40. Please comment any existing typos in README.md in this issue. :+1:

inhibitor1217 avatar Dec 20 '21 11:12 inhibitor1217