angstrom icon indicating copy to clipboard operation
angstrom copied to clipboard

Published 20 hours ago • verified publisher icon inhabitedtype

Make parser combiner lazy

Open RCmerci opened this issue 3 years ago • 1 comments

related to #209

RCmerci avatar Feb 24 '21 06:02 RCmerci

I've been running into stack overflow on 0.15.0 as well, which is surprising to me because #186 and #187 are very similar to the changes I've made on my old fork which does not have stack overflow issues.

It turns out the reason is the changes made by #186 and #187 aren't fully lazy.

This PR fixed all remaining stack overflows on 0.15.0 for me! 🎉 It passes all my tests on SZXX. However the impact on performance seems to be a slowdown of ~55%. I'd still support merging it, maybe along with #217 to (more than) cancel out the impact on performance?

SGrondin avatar Oct 04 '21 14:10 SGrondin