git-subrepo icon indicating copy to clipboard operation
git-subrepo copied to clipboard

new push parameters: --tag / --tag-refresh

Open oboukili opened this issue 7 years ago • 13 comments

Hello,

This PR introduces --tag and --tag-refresh parameters to the push command:

  The `--tag` option will apply a given (non-annotated) tag to the specified
  subrepos' upstream HEAD, provided that they were staged for changes, leaving
  the parent repository unchanged.

  The `--tag-refresh` will apply the given tag (with `--tag`) to all specified
  subrepos' upstream HEAD even if they were not staged for changes.

I had a need to push to multiple subrepos, passing on a common information. I thought a tag would be a good way to do it.

This should also resolve issue https://github.com/ingydotnet/git-subrepo/issues/188.

I also fixed some cleaning bugs with the delete-branch -> delete-worktree calls. I've based of this PR on the release/0.4.0 branch.

Cheers,

oboukili avatar Jan 20 '18 15:01 oboukili

I would appreciate some help with the CI tests failing :) I don't know where to look at.

oboukili avatar Jan 20 '18 15:01 oboukili

@grimmySwe or @ingydotnet would you have some time to give me a hand?

oboukili avatar Jun 15 '18 16:06 oboukili

This PR sounds great for pushing tags altogether, wish it could have a go

JacopKane avatar Aug 08 '18 23:08 JacopKane

Still no news, hard at work I presume? Cheers

oboukili avatar Oct 22 '18 09:10 oboukili

Why was it closed?

oboukili avatar Nov 11 '18 17:11 oboukili

@oboukili hmm. Looks like my fault. Since 0.4.0 is now on master I deleted the release/0.4.0 branch, and that seems to have auto-closed this.

Can you see if it is possible to re-target master?

I wonder how many other PRs I closed by doing this.

@grimmySwe take note...

ingydotnet avatar Nov 11 '18 18:11 ingydotnet

I had a list of 12 open PRs before I unwittingly auto-closed them. The auto-closed ones are:

  • #379
  • #358
  • #356
  • #337
  • #332
  • #314
  • #284

ingydotnet avatar Nov 11 '18 18:11 ingydotnet

I can try to repush the release/0.4.0 branch and see what happens to the 7 closed PRs.

ingydotnet avatar Nov 11 '18 18:11 ingydotnet

I re-pushed release/0.4.0 and clicked the 'Reopen pull request' button.

This PR still needs to re-target master I would think. @oboukili let me know if you figure out how to do that.

I'll reopen the others for now, and wait for more clarity.

ingydotnet avatar Nov 11 '18 18:11 ingydotnet

@ingydotnet alright I changed the PR's base branch to target master instead.

oboukili avatar Nov 13 '18 08:11 oboukili

Was this closed because you were tired of waiting or because you found a better solution? I am still working through the backlog and this seems like a great patch.

admorgan avatar May 09 '20 14:05 admorgan

Hello Indeed it has been more than a year, I was doing some old PR cleanup, I can reopen it if it is still of some interest.

oboukili avatar May 10 '20 07:05 oboukili

This would be a great feature!

twpedersen avatar Dec 06 '23 23:12 twpedersen