probatus icon indicating copy to clipboard operation
probatus copied to clipboard

Compatibility early stopping with old lgbm

Open Alcoholrithm opened this issue 2 years ago • 1 comments

Fixes #187

'lightgbm.print_evaluation' was renamed to 'log_evaluation' after lgbm 3.3.0

Alcoholrithm avatar May 20 '22 10:05 Alcoholrithm

I don't think Probatus strives to accommodate several versions of lightgbm. You can fix this by upgrading to lightgbm>=3.3.0 in your codebase.

christophermadsen avatar Aug 10 '22 09:08 christophermadsen

Hi @Alcoholrithm ,

Thank you for your time and effort in putting together this pull request. We appreciate your willingness to contribute to Probatus.

While your changes have merit, we're striving to keep the Probatus package up-to-date. After reviewing your pull request, it appears that some aspects of the proposed changes do not adhere to this goal. Otherwise, this could cause compatibility issues with newer versions of the libraries we are using.

To address this, I would suggest updating libraries that you use in your codebase.

I encourage you to incorporate this suggestion and resubmit pull request of other issues you might find. If you have any questions or need further clarification, please feel free to reach out.

ReinierKoops avatar Jun 04 '23 05:06 ReinierKoops