lion icon indicating copy to clipboard operation
lion copied to clipboard

[lion-input-stepper] Value change is not announced by screen reader (Chrome + NVDA)

Open riovir opened this issue 2 years ago • 4 comments

At the time of writing, using the latest Chrome (v109.0.5414.120) and NVDA (2022.4.0.27401) with Tools > Speach Viewer on, open https://lion-web.netlify.app/components/input-stepper/overview/ the tab to the LionInputStepper. Press the up arrow key 3 times. The stepper will correctly show 3.

Expected behavior

The screen reader / speech viewer also describes the component and more importantly announces the 1, 2, 3 values as the arrow key is pressed.

Actual Behavior

No announcement happens. The user seemingly is left guessing the value of the component.

Additional context

Repeated the same test with Firefox. The screen reader correctly describes the component and announces the values as well. At the time of reporting it's unclear what makes Chrome special.

riovir avatar Jan 25 '23 12:01 riovir

I actually know what is causing the bug. The issue is that role="spinbutton" is on the . When removing that and setting it on the input nod instead it works as expected. I verified this using the dev tools to move the role and testing with NVDA (v2022.4.0.27401) and Chrome (v109.0.5414.75)

Sciurus7 avatar Jan 25 '23 14:01 Sciurus7

@riovir thanks for the issue @Sciurus7 thanks for the fix! Is any of you also willing to contribute it via a PR?

gerjanvangeest avatar Jan 25 '23 15:01 gerjanvangeest

I can create a PR on Friday. (Need to focus on my sprint work for today and tomorrow.)

Sciurus7 avatar Jan 25 '23 15:01 Sciurus7

I can create a PR on Friday. (Need to focus on my sprint work for today and tomorrow.)

Any progress so far @Sciurus7?

tlouisse avatar Feb 14 '23 17:02 tlouisse