lion icon indicating copy to clipboard operation
lion copied to clipboard

fix(form-core) sync autofocus to focusable node (fixes #1775)

Open Sciurus7 opened this issue 3 years ago • 2 comments

What I did

  1. In FocusMixin synced the autofocus attribute from the host to the focusable node.
  2. Added tests to ensure the sync happens if autofocus was set on the host during render or when autofocus is added or removed from the host.

Sciurus7 avatar Sep 09 '22 10:09 Sciurus7

⚠️ No Changeset found

Latest commit: 5a4b794ceea040c7bc0c09ebb88d5e7cdc6b9c4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 09 '22 10:09 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 09 '22 10:09 CLAassistant

Hi @Sciurus7, thanks for the contribution! Somehow i missed this one completely, my excuses. Could you resolve the conflicts and add a changeset (npm run changeset)?

fix: https://github.com/ing-bank/lion/issues/1775

gerjanvangeest avatar Apr 04 '23 07:04 gerjanvangeest

Hi Gerjan, I finally managed to get my personal git account in a working state again. While trying to bring this pull request up to date I messed up a merge, so instead of trying to fix that particular mess, I branched of master again added the changes to an up to date branch and created a new pull request. This one should be up to date and has a change set. I will close this pull request accordingly.

Sciurus7 avatar Apr 14 '23 11:04 Sciurus7