flink-deployer
flink-deployer copied to clipboard
Support savepoints on AWS S3
Codecov Report
Merging #39 into master will decrease coverage by
2.24%. The diff coverage is9.67%.
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 52.91% 50.66% -2.25%
==========================================
Files 13 13
Lines 567 598 +31
==========================================
+ Hits 300 303 +3
- Misses 218 245 +27
- Partials 49 50 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| cmd/cli/operations/retrieve_savepoint.go | 41.17% <9.67%> (-48.83%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 706b264...a1c98e2. Read the comment docs.
I'm happy to remove them, but there are lots of files committed under vendor in master, I assumed you guys were vendoring dependencies?
I am not sure why it happens before either, is it necessary to add a .gitignore to remove vendor in master ? @mrooding
If it does, I would like to do it.
Thanks for the contribution @kerinin.
We do actually commit the vendor directory. As stated in the dep FAQ (https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory), it does have a con of polluting the PR but it also has some nice advantages.
I'll get to reviewing this beginning of next week!
@mrooding, is there anyway you could review and and get this PR merged asap? I need this functionality. Thanks @kerinin