flink-deployer icon indicating copy to clipboard operation
flink-deployer copied to clipboard

Support savepoints on AWS S3

Open kerinin opened this issue 6 years ago • 5 comments

kerinin avatar May 16 '19 19:05 kerinin

Codecov Report

Merging #39 into master will decrease coverage by 2.24%. The diff coverage is 9.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   52.91%   50.66%   -2.25%     
==========================================
  Files          13       13              
  Lines         567      598      +31     
==========================================
+ Hits          300      303       +3     
- Misses        218      245      +27     
- Partials       49       50       +1
Impacted Files Coverage Δ
cmd/cli/operations/retrieve_savepoint.go 41.17% <9.67%> (-48.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 706b264...a1c98e2. Read the comment docs.

codecov-io avatar May 16 '19 19:05 codecov-io

I'm happy to remove them, but there are lots of files committed under vendor in master, I assumed you guys were vendoring dependencies?

kerinin avatar May 17 '19 15:05 kerinin

I am not sure why it happens before either, is it necessary to add a .gitignore to remove vendor in master ? @mrooding

If it does, I would like to do it.

hustclf avatar May 18 '19 02:05 hustclf

Thanks for the contribution @kerinin.

We do actually commit the vendor directory. As stated in the dep FAQ (https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory), it does have a con of polluting the PR but it also has some nice advantages.

I'll get to reviewing this beginning of next week!

mrooding avatar May 19 '19 08:05 mrooding

@mrooding, is there anyway you could review and and get this PR merged asap? I need this functionality. Thanks @kerinin

joshuavijay avatar Sep 17 '19 15:09 joshuavijay