Confusing error message

Open greg-szabo opened this issue 3 years ago • 2 comments

Michael was trying to broadcast a test message from a 3-of-5 multisig address. The command should obviously fail, because he didn't sign it and it was just a test. But the error message was misleading:

Error: Insufficient signatures for broadcast. Requires 2, got 0

Michael's correct response:

This one actually requires three…

May 09 '22 15:05 greg-szabo

This message is confusing because the signature threshold is hard-coded in the code to, it's set to '2'. There's a TODO message saying that the threshold should be part of the config

https://github.com/informalsystems/multisig/blob/34d19b001af8976fb9896685d82387200a31b746/main.go#L718

May 10 '22 20:05 andynog

This is related to informalsystems/validator#246 . Close it when that's done.

May 25 '22 14:05 greg-szabo